Fix decode error#4
Merged
Merged
Conversation
* quick fix for ignoring a usual location for venv. * decode using iso-8859-1 and if this fails, raise the MWSError with the original xml attached to .response * comment in the code to show WHY we are returning this. The developer using this can then take a good look at the XML to find out why it has failed to decode and report back to us any issues. * duplicate the tests and inject a known problem char (\x94) to make sure the decoding works. These tests are currently not passing on my computer due to hashable object issues with pytest, but were quite happy on Github actions. Committing and pushing to see what result we get in the pipeline. * code format with black. * Test re-writes, should work now. * Black formatting fix Co-authored-by: Galen Rice <galen.s.rice@gmail.com>
acmenna
approved these changes
Aug 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix https://sentry.io/organizations/shiphero-0x/issues/1835978176/events/?project=5336827&statsPeriod=7d