close
Skip to content

Add HasDisposeBag.swift to SwiftPM#82

Merged
ashfurrow merged 1 commit into
RxSwiftCommunity:masterfrom
mtfum:add-HasDisposeBag
Apr 23, 2020
Merged

Add HasDisposeBag.swift to SwiftPM#82
ashfurrow merged 1 commit into
RxSwiftCommunity:masterfrom
mtfum:add-HasDisposeBag

Conversation

@mtfum
Copy link
Copy Markdown
Member

@mtfum mtfum commented Apr 18, 2020

#trivial
We can't use HasDisposeBag when using SwiftPM.
So I added file source!
please review, thanks!

@mtfum mtfum requested a review from pomozoff April 18, 2020 08:51
@rxswiftcommunity
Copy link
Copy Markdown

rxswiftcommunity Bot commented Apr 18, 2020

It looks like code was changed without adding anything to the Changelog.

Generated by 🚫 dangerJS

@mtfum mtfum requested a review from ashfurrow April 18, 2020 08:51
Copy link
Copy Markdown
Member

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Sorry for the delay, let me get this released for you 👍

@ashfurrow ashfurrow merged commit 36839a6 into RxSwiftCommunity:master Apr 23, 2020
@ashfurrow
Copy link
Copy Markdown
Member

Okay! That's released as 5.1.1 🌟

Thanks again!

@mtfum mtfum deleted the add-HasDisposeBag branch April 25, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants