close
Skip to content

Add SPM support#79

Merged
ashfurrow merged 4 commits into
RxSwiftCommunity:masterfrom
pomozoff:master
Feb 26, 2020
Merged

Add SPM support#79
ashfurrow merged 4 commits into
RxSwiftCommunity:masterfrom
pomozoff:master

Conversation

@pomozoff
Copy link
Copy Markdown
Contributor

@pomozoff pomozoff commented Feb 26, 2020

#trivial

@rxswiftcommunity
Copy link
Copy Markdown

rxswiftcommunity Bot commented Feb 26, 2020

It looks like code was changed without adding anything to the Changelog.

Thanks a lot for contributing @pomozoff! I've invited you to join the
RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like
more information on what this means, check out our contributor guidelines
and feel free to reach out with any questions.

Generated by 🚫 dangerJS

@pomozoff pomozoff mentioned this pull request Feb 26, 2020
@ashfurrow
Copy link
Copy Markdown
Member

Thanks for opening the PR!

It looks like CocoaPods is adding Package.swift to the CocoaPod podspec 😅

s.source_files = "*.swift"

I think we can change this line to %w(NSObject+Rx.swift HasDisposeBag.swift) to fix CI. That and a changelog entry, and we should be good to merge!

@pomozoff
Copy link
Copy Markdown
Contributor Author

@ashfurrow, thanks for helping! Should I replace s.source_files = "*.swift" with s.source_files = "%w(NSObject+Rx.swift HasDisposeBag.swift)"?

@ashfurrow
Copy link
Copy Markdown
Member

Nearly! The "quotes" shouldn't be there. The way %w() works in Ruby is that it looks for whitespace in the parens, and separates out the text into an array divided by that whitespace. The following two lines are functionally identical:

s.source_files = ["NSObject+Rx.swift", "HasDisposeBag.swift"]
s.source_files = %w(NSObject+Rx.swift HasDisposeBag.swift)

One is just easier to copy/paste filenames into, so you see %w() (or %w[]) used a lot in Ruby :👍 Let me know what I can clarify.

@pomozoff
Copy link
Copy Markdown
Contributor Author

Thank you a lot! Everything is clear now )

Copy link
Copy Markdown
Member

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge when CI is green. Then we can tag a release 👍

@ashfurrow ashfurrow merged commit 1c12859 into RxSwiftCommunity:master Feb 26, 2020
@ashfurrow
Copy link
Copy Markdown
Member

Okay, tagged a release of 5.0.3 on git. Let me know if I can help further, and thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants