close
Skip to content

Swift 4.2 in podspec and .swift-version#59

Merged
ashfurrow merged 3 commits into
RxSwiftCommunity:masterfrom
fassko:master
Sep 26, 2018
Merged

Swift 4.2 in podspec and .swift-version#59
ashfurrow merged 3 commits into
RxSwiftCommunity:masterfrom
fassko:master

Conversation

@fassko
Copy link
Copy Markdown
Member

@fassko fassko commented Sep 26, 2018

Otherwise Xcode shows warning

@fassko fassko self-assigned this Sep 26, 2018
@fassko fassko requested a review from ashfurrow September 26, 2018 14:09
Copy link
Copy Markdown
Member

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Do you want this released? I could add you as an owner to the CocoaPod. It's as easy as git tag 4.4.1 && git push --tags && pod trunk push --allow-warnings.

@ashfurrow ashfurrow merged commit 86d6c99 into RxSwiftCommunity:master Sep 26, 2018
@fassko
Copy link
Copy Markdown
Member Author

fassko commented Sep 26, 2018

@ashfurrow Yes, I can release it and also work on #8 to Automate releases.

@ashfurrow
Copy link
Copy Markdown
Member

Cool, that would be awesome, especially since we should be able to reproduce that work across other RxSwiftCommunity repos 👍 I've added you as an owner, let me know what else I can do to help. Thanks so much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants