Add default material::scatter() implementation#1455
Merged
Conversation
The code mixes up `material::scatter()` with and without a default implementation. This causes problems as the `diffuse_light` (derived from the `material` class) first defines its own no-op implementation, but later the signature of `material::scatter()` changes without associated updates to the `diffuse_light` class. All of this is fixed by giving `material::scatter()` a no-op default implementation, which `diffuse_light` just uses implicitly. Thus, when the signature is changed, `diffuse_light` requires no updates. Resolves #1379
armansito
approved these changes
Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code mixes up
material::scatter()with and without a default implementation. This causes problems as thediffuse_light(derived from thematerialclass) first defines its own no-op implementation, but later the signature ofmaterial::scatter()changes without associated updates to thediffuse_lightclass.All of this is fixed by giving
material::scatter()a no-op default implementation, whichdiffuse_lightjust uses implicitly. Thus, when the signature is changed,diffuse_lightrequires no updates.Resolves #1379