fix: pipeline improvements + SKILL.md refactor (follow-up to #15892)#15927
Open
qfai wants to merge 5 commits into
Open
fix: pipeline improvements + SKILL.md refactor (follow-up to #15892)#15927qfai wants to merge 5 commits into
qfai wants to merge 5 commits into
Conversation
1. Fix GIF upload: use multipart form-data (-F flag) instead of raw binary (--data-binary). GitHub's uploads.github.com API requires multipart; the old approach returned 'Multipart form data required' silently, so screenshots never appeared in issue comments. 2. Fix PR creation: add Step 0.5 to Copilot agent prompt to read non-bot issue comments and act on user instructions (fix code, create PR, retry) before running tests. 3. Fix retry: add retry loop (up to 2x, 30s delay) around the ts-node test run inside the agent prompt, and a second retry loop around the copilot --yolo invocation at the workflow level. Both retries detect infrastructure failures (no results produced) vs real test failures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ategy
The Copilot agent prompt is now loaded from packages/tests/copilot-test/SKILL.md
at runtime (cat'd into the prompt before each run). This makes the agent
instructions maintainable independently of the workflow YAML.
SKILL.md defines three operating modes based on issue + comment analysis:
Mode A: test-only -> no PR, just run and report
Mode B: new test needed -> PR on branch test/issue-{N}-copilot (test files only)
Mode C: fix/feature -> PR on branch fix/issue-{N}-copilot (code changes)
Same-PR rule: if a branch already exists for this issue, reuse it.
Docker is framed as the agent's verification tool, not just a local dev aid.
Issue comments are documented as the cross-session memory (since each label
trigger is a fresh stateless Copilot session).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #15927 +/- ##
=======================================
Coverage 93.34% 93.34%
=======================================
Files 590 590
Lines 37198 37198
Branches 6785 6812 +27
=======================================
Hits 34721 34721
Misses 1831 1831
Partials 646 646 🚀 New features to boost your workflow:
|
COPILOT_CLI_RUNNER_TOKEN gets 403 even for issue comments (token lacks org write access). Revert agent step to GITHUB_TOKEN which CAN post comments but cannot create PRs (org policy blocks both tokens equally). Add explicit constraint to SKILL.md: do NOT attempt gh pr create. Instead push the branch and tell the user the branch name + manual PR creation command. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
gh pr create returns 403 (org policy). Agent should NOT attempt it. Document the constraint explicitly so the agent pushes the branch and tells the user to open the PR manually. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three post-merge pipeline fixes + SKILL.md refactor (follow-up to #15892).
Cleanly rebased on latest dev (2026-05-15).
Changes
Fix 1 - Screenshots not appearing in issue
Fix 2 - Agent ignores user comments
Fix 3 - No retry on test failure
Refactor - Extract SKILL.md
Agent prompt now loaded at runtime from packages/tests/copilot-test/SKILL.md.
Introduces 3-mode decision framework:
Same-PR rule: reuse existing branch/PR for same issue.