Made version.py compatible with Python 2.6 (and maybe older)#3
Conversation
Owner
|
Thanks for contributing @shatsinn. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your package, changaco!
Recently, I integrated it into our CMS project and it seems to work fine. Our CI discovered an issue with running the tests on Python 2.6 caused by using subprocess.check_output .
The commit will not change functionality (i hope), but just establishes support for 2.6 and maybe older versions. I can't tell for sure if there are any more issues, but our tests using several API calls run fine with this.
Maybe you have another solution, please let me know.
Thanks,