E2E on build zip#137
Merged
Merged
Conversation
peterwilsoncc
left a comment
Contributor
There was a problem hiding this comment.
LGTM pending the branch change.
To test, I compared the zip file attached to the action with the zip file in the WordPress plugin repo. They are identical.
Member
|
@peterwilsoncc what's the branch change you're referencing here? |
Contributor
|
@jeffpaul On this line ads-txt/.github/workflows/cypress.yml Line 13 in d707145 Although it occurs to me that we might be able to use the file reference to refer to the current branch. I'll push and merge if that works. |
a177aee to
51bd9e3
Compare
peterwilsoncc
approved these changes
Apr 4, 2023
peterwilsoncc
left a comment
Contributor
There was a problem hiding this comment.
I pushed 51bd9e3 to use the workflow file from the current branch, this allows for PRs requiring changes to the zip to be worked on without issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
PR contains changes to Run E2E tests on the zip generated by "Build release zip" action to catch release zip bugs early and at the PR level instead of manual testing before release.
Closes #122
Changelog Entry
Credits
Props @jayedul
Checklist: