Display PHP version names in unit test workflow.#133
Merged
Conversation
jeffpaul
approved these changes
Mar 7, 2023
jeffpaul
left a comment
Member
There was a problem hiding this comment.
Yep, I see "phpunit" for all runs prior and the run on this PR shows the correct PHP version for each, nice update Peter!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Corrects the reference in the
namesection of the unit tests to differentiate between PHP versions.Restores the PHP Unit tests for PHP 8.0 as they are listed as required in the repos config.
Closes #132
How to test the Change
PHP 7.4,PHP 8.0andPHP 8.1(on develop these both show asphpunit).Changelog Entry
Credits
Props @peterwilsoncc, @jeffpaul.
Checklist: