gh-100522 Add a test for 'futures.as_completed' timing out with a non-zero timeout value #100523
+22
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosephSBoyle
changed the title
JosephSBoyle
commented
Dec 25, 2022
|
|
||
| future = self.executor.submit(time.sleep, 0.1) |
There was a problem hiding this comment.
The test actually sleeps this long (possibly when the thread is torn down?) so reducing the time from 2s is quite beneficial for test runtime. Particularly so as this test is expanded to run multiple times:
2s sleep:
0.1s sleep:
Python + pytest on 3.12 with the command:
./python -m pytest Lib/test/test_concurrent_futures.py -k test_future_times_out -vvv
JosephSBoyle
force-pushed
the
fix-issue-100522
branch
3 times, most recently
from
db6c886
to
087c339
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Resolves a longstanding TODO in the futures tests:
by fixturizing the existing test.
test_concurrent_futures.py#100522