doc: improve TLS/SSL introduction #41649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
reviewed
Jan 22, 2022
Trott
reviewed
Jan 22, 2022
lpinca
approved these changes
Jan 22, 2022
cjihrig
approved these changes
Jan 23, 2022
richardlau
approved these changes
Jan 23, 2022
tniessen
force-pushed
the
doc-rephrase-tls-introduction
branch
from
11988b0
to
82a5eaa
Compare
|
@Trott Thanks for the suggestions, PTAL :) |
Trott
approved these changes
Jan 23, 2022
RaisinTen
approved these changes
Jan 23, 2022
Commit Queue failed- Loading data for nodejs/node/pull/41649 ✔ Done loading data for nodejs/node/pull/41649 ----------------------------------- PR info ------------------------------------ Title doc: improve TLS/SSL introduction (#41649) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:doc-rephrase-tls-introduction -> nodejs:master Labels tls, doc Commits 1 - doc: improve TLS/SSL introduction Committers 1 - Tobias Nießen PR-URL: https://github.com/nodejs/node/pull/41649 Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig Reviewed-By: Richard Lau Reviewed-By: Darshan Sen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41649 Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig Reviewed-By: Richard Lau Reviewed-By: Darshan Sen -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 22 Jan 2022 14:45:05 GMT ✔ Approvals: 5 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/41649#pullrequestreview-860281136 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41649#pullrequestreview-860235044 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/41649#pullrequestreview-860253111 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/41649#pullrequestreview-860254053 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/41649#pullrequestreview-860317353 ✖ This PR needs to wait 6 more minutes to land ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1740375907 |
Commit Queue failed- Loading data for nodejs/node/pull/41649 ✔ Done loading data for nodejs/node/pull/41649 ----------------------------------- PR info ------------------------------------ Title doc: improve TLS/SSL introduction (#41649) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:doc-rephrase-tls-introduction -> nodejs:master Labels tls, doc, commit-queue-failed Commits 1 - doc: improve TLS/SSL introduction Committers 1 - Tobias Nießen PR-URL: https://github.com/nodejs/node/pull/41649 Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig Reviewed-By: Richard Lau Reviewed-By: Darshan Sen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41649 Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig Reviewed-By: Richard Lau Reviewed-By: Darshan Sen -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 22 Jan 2022 14:45:05 GMT ✔ Approvals: 5 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/41649#pullrequestreview-860281136 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41649#pullrequestreview-860235044 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/41649#pullrequestreview-860253111 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/41649#pullrequestreview-860254053 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/41649#pullrequestreview-860317353 ✖ This PR needs to wait 5 more minutes to land ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1740412607 |
|
Landed in 3657c14 |
Linkgoron
added a commit
to Linkgoron/node
that referenced
this issue
Jan 31, 2022
PR-URL: nodejs#41649 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
ruyadorno
added a commit
that referenced
this issue
Feb 8, 2022
PR-URL: #41649 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams
added a commit
that referenced
this issue
Mar 2, 2022
PR-URL: #41649 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams
added a commit
that referenced
this issue
Mar 3, 2022
PR-URL: #41649 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams
added a commit
that referenced
this issue
Mar 14, 2022
PR-URL: #41649 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
TLS/SSL is not a public key infrastructure. It is a set of protocols that use a public key infrastructure. Also add the purpose of TLS/SSL (secure communication) to the very beginning.