added text_to_speech by asperduti · Pull Request #3679 · TheAlgorithms/Python

asperduti · 2020-10-23T21:34:08Z

Describe your change:

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

dhruvmanila

Please provide tests from the following, whichever you prefer:
doctest, unittest, pytest

other/text_to_speech.py

dhruvmanila

You would also require to write tests for the function. This would be a bit difficult so if you face any problem, ping me, but before that please try first.

other/text_to_speech.py

Split text_to_speech function.

asperduti · 2020-11-26T16:17:37Z

You would also require to write tests for the function. This would be a bit difficult so if you face any problem, ping me, but before that please try first.

Hi @dhruvmanila
Well, after some troubles, I did it. Please tell me if you need more tests or something else.

I structured the code differently, I split it up to make easier the testing.

other/text_to_speech.py

asperduti · 2020-12-11T14:08:27Z

Hi @dhruvmanila I worked on all the requested changes.

stale · 2021-01-11T04:47:02Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

asperduti · 2021-01-11T11:20:15Z

Hi, @ xcodz-dot , @dhruvmanila .

Did you check it?
I worked in the things that you told me.

ghost

looks good

stale · 2021-02-13T11:40:09Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

ghost · 2021-02-16T06:45:20Z

cc: @cclauss

dhruvmanila · 2021-02-17T13:55:02Z

Hi, I will take a look at this in a day or two.

cclauss · 2021-02-17T14:13:03Z

other/tests/test_text_to_speech.py

+        html = "<p>Listen to the MP3 file  :<BR></p> <!> \
+                <object classid='clsid:D27CDB6E-AE6D-11cf-96B8-444553540000' \
+                        width='470' height='24' id='single1' name='single1'> \
+                <param name='movie' value='player.swf'> \
+                <param name='allowfullscreen' value='true'> \
+                <param name='allowscriptaccess' value='always'> \
+                <param name='wmode' value='transparent'> \
+                <param name = 'flashvars' \
+                       value='file=/output/0360061001606401513/59405670.mp3'> \
+                <embed \
+                    id='single2' \
+                    name='single2' \
+                    src='player.swf' \
+                    width='470' \
+                    height='24' \
+                    bgcolor='#000000' \
+                    allowscriptaccess='always' \
+                    allowfullscreen='true' \
+                    flashvars='file=/output/0360061001606401513/59405670.mp3' \
+                /> \
+                </object>"


Triple-quoted multiline strings work in Python and as PEP8 says, backslashes should be avoided in Python code.

Suggested change

html = "Listen to the MP3 file : <!> \

<object classid='clsid:D27CDB6E-AE6D-11cf-96B8-444553540000' \

width='470' height='24' id='single1' name='single1'> \

<param name='movie' value='player.swf'> \

<param name='allowfullscreen' value='true'> \

<param name='allowscriptaccess' value='always'> \

<param name='wmode' value='transparent'> \

<param name = 'flashvars' \

value='file=/output/0360061001606401513/59405670.mp3'> \

<embed \

id='single2' \

name='single2' \

src='player.swf' \

width='470' \

height='24' \

bgcolor='#000000' \

allowscriptaccess='always' \

allowfullscreen='true' \

flashvars='file=/output/0360061001606401513/59405670.mp3' \

/> \

</object>"

html = """Listen to the MP3 file : <!>

<object classid='clsid:D27CDB6E-AE6D-11cf-96B8-444553540000'

width='470' height='24' id='single1' name='single1'>

<param name='movie' value='player.swf'>

<param name='allowfullscreen' value='true'>

<param name='allowscriptaccess' value='always'>

<param name='wmode' value='transparent'>

<param name = 'flashvars'

value='file=/output/0360061001606401513/59405670.mp3'>

<embed

id='single2'

name='single2'

src='player.swf'

width='470'

height='24'

bgcolor='#000000'

allowscriptaccess='always'

allowfullscreen='true'

flashvars='file=/output/0360061001606401513/59405670.mp3'

/>

</object>"""

cclauss · 2021-02-17T14:14:33Z

other/text_to_speech.py

+import requests
+
+LANGUAGES_VOICES = {
+    "US English": ["Alice", "Daisy", "George", "Jenna", "John"],


Suggested change

"US English": ["Alice", "Daisy", "George", "Jenna", "John"],

"US English": ("Alice", "Daisy", "George", "Jenna", "John"),

Tuples take less RAM than lists and they indicate to the reader that the values will not change at runtime.

cclauss · 2021-02-17T14:16:21Z

other/text_to_speech.py

+    if match := re.search(r"\/output\/\d+\/\d+\.mp3", html):
+        filename = match.group()
+    else:
+        filename = None
+
+    return filename


Suggested change

if match := re.search(r"\/output\/\d+\/\d+\.mp3", html):

filename = match.group()

else:

filename = None

return filename

match = re.search(r"\/output\/\d+\/\d+\.mp3", html):

return match.group() if match else None

cclauss · 2021-02-17T14:19:21Z

other/text_to_speech.py

+}
+
+
+def get_mp3_filename(html: str) -> Optional[str]:


Why two different return types? Why not just return an empty str instead of None?

cclauss · 2021-02-17T14:20:36Z

other/text_to_speech.py

+    audio_url = f"http://www.fromtexttospeech.com{mp3_file}"
+
+    mp3data = requests.get(audio_url)


Suggested change

audio_url = f"http://www.fromtexttospeech.com{mp3_file}"

mp3data = requests.get(audio_url)

mp3data = requests.get(f"http://www.fromtexttospeech.com{mp3_file}")

This is not really mp3data. Instead, it is a requests.Response so perhaps response would be a better variable name than mp3data.

cclauss · 2021-02-17T14:25:32Z

other/text_to_speech.py

+    # save the data as an mp3 file
+    if mp3data.status_code != 404:
+        with open(audio_path, "w+b") as f:
+            f.write(mp3data.content)
+        return True
+
+    return False


Suggested change

# save the data as an mp3 file

if mp3data.status_code != 404:

with open(audio_path, "w+b") as f:

f.write(mp3data.content)

return True

return False

try:

response.raise_for_status()

# save the data as an mp3 file

with open(audio_path, "wb") as f:

f.write(response.content)

return True

except requests.HTTPError:

return False

cclauss · 2021-02-17T14:27:15Z

other/tests/test_text_to_speech.py

+        self.assertEqual("/output/0360061001606401513/59405670.mp3", mp3_file_name)
+
+    def test_get_mp3_file_invalid_html(self):
+        html = "<p>Listen to the MP3 file  :<BR></p> <!> \


Triple-quoted str with no backslashes please.

stale · 2021-03-19T23:10:44Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2021-06-05T00:37:13Z

Please reopen this pull request once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions!

added text_to_speech

c290141

dhruvmanila requested changes Nov 9, 2020

View reviewed changes

other/text_to_speech.py Outdated Show resolved Hide resolved

other/text_to_speech.py Outdated Show resolved Hide resolved

dhruvmanila added require tests Tests [doctest/unittest/pytest] are required awaiting changes A maintainer has requested changes to this PR labels Nov 9, 2020

dhruvmanila requested changes Nov 26, 2020

View reviewed changes

other/text_to_speech.py Outdated Show resolved Hide resolved

other/text_to_speech.py Outdated Show resolved Hide resolved

asperduti added 2 commits November 26, 2020 12:31

Replace curl by requests.

afc5f1e

Split text_to_speech function.

Add tests to text_to_speech

d019195

asperduti added 3 commits November 26, 2020 12:55

Fixs PEP8 and tests.

a841906

Fix length

947a783

Fix imports

0a80467

ghost added awaiting reviews This PR is ready to be reviewed and removed tests are failing Do not merge until tests pass labels Nov 26, 2020

dhruvmanila requested changes Dec 10, 2020

View reviewed changes

ghost added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Dec 10, 2020

Adds docstring and requested changes.

45e9a3b

ghost added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass and removed awaiting changes A maintainer has requested changes to this PR awaiting reviews This PR is ready to be reviewed labels Dec 11, 2020

Fix isort

9d959c6

ghost added awaiting reviews This PR is ready to be reviewed and removed tests are failing Do not merge until tests pass labels Dec 11, 2020

stale bot added the stale Used to mark an issue or pull request stale. label Jan 11, 2021

stale bot removed the stale Used to mark an issue or pull request stale. label Jan 11, 2021

ghost approved these changes Jan 12, 2021

View reviewed changes

stale bot added the stale Used to mark an issue or pull request stale. label Feb 13, 2021

stale bot removed the stale Used to mark an issue or pull request stale. label Feb 16, 2021

dhruvmanila self-requested a review February 17, 2021 13:55

cclauss reviewed Feb 17, 2021

View reviewed changes

stale bot added the stale Used to mark an issue or pull request stale. label Mar 19, 2021

stale bot closed this Jun 5, 2021

Jan	FEB	Mar
	15
2025	2026	2027

	"US English": ["Alice", "Daisy", "George", "Jenna", "John"],
	"US English": ("Alice", "Daisy", "George", "Jenna", "John"),

		audio_url = f"http://www.fromtexttospeech.com{mp3_file}"

		mp3data = requests.get(audio_url)

Uh oh!

Conversation

asperduti commented Oct 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your change:

Checklist:

Uh oh!

dhruvmanila left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dhruvmanila left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

asperduti commented Nov 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

asperduti commented Dec 11, 2020

Uh oh!

stale bot commented Jan 11, 2021

Uh oh!

asperduti commented Jan 11, 2021

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

stale bot commented Feb 13, 2021

Uh oh!

ghost commented Feb 16, 2021

Uh oh!

dhruvmanila commented Feb 17, 2021

Uh oh!

cclauss Feb 17, 2021

Choose a reason for hiding this comment

Uh oh!

cclauss Feb 17, 2021

Choose a reason for hiding this comment

Uh oh!

cclauss Feb 17, 2021

Choose a reason for hiding this comment

Uh oh!

cclauss Feb 17, 2021

Choose a reason for hiding this comment

Uh oh!

cclauss Feb 17, 2021

Choose a reason for hiding this comment

Uh oh!

cclauss Feb 17, 2021

Choose a reason for hiding this comment

Uh oh!

cclauss Feb 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cclauss Feb 17, 2021

Choose a reason for hiding this comment

Uh oh!

stale bot commented Mar 19, 2021

Uh oh!

stale bot commented Jun 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

asperduti commented Oct 23, 2020 •

edited

Loading

asperduti commented Nov 26, 2020 •

edited

Loading

cclauss Feb 17, 2021 •

edited

Loading