close
The Wayback Machine - https://web.archive.org/web/20260214211343/https://github.com/TheAlgorithms/Python/pull/2645
Skip to content

pig_latin#2645

Closed
kadambinipanda wants to merge 4 commits intoTheAlgorithms:masterfrom
kadambinipanda:master
Closed

pig_latin#2645
kadambinipanda wants to merge 4 commits intoTheAlgorithms:masterfrom
kadambinipanda:master

Conversation

@kadambinipanda
Copy link

@kadambinipanda kadambinipanda commented Oct 2, 2020 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@spamegg1
Copy link
Contributor

spamegg1 commented Oct 3, 2020

pre-commit is failing because there are no empty lines at the end of the files.

Running black on your files can fix these simple issues. See CONTRIBUTING.md for info.

@stale
Copy link

stale bot commented Nov 21, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Nov 21, 2020
@stale stale bot removed the stale Used to mark an issue or pull request stale. label Dec 6, 2020
@ghost ghost added require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass and removed awaiting reviews This PR is ready to be reviewed labels Dec 6, 2020
@l3str4nge
Copy link
Member

l3str4nge commented Dec 10, 2020

Pleas read contribution guidelines and reopen pull request. Closing.

@l3str4nge l3str4nge closed this Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@l3str4nge l3str4nge Awaiting requested review from l3str4nge

Assignees

No one assigned

Labels

require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html tests are failing Do not merge until tests pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kadambinipanda @spamegg1 @l3str4nge