Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uprefactor: add support for TypeScript 4.0 #20368
Merged
Conversation
alan-agius4
changed the title
alan-agius4
force-pushed the
alan-agius4:ts4-build-refactor
branch
8 times, most recently
from
d65b6eb
to
7a00768
alan-agius4
requested review from
andrewseguin,
crisbeto,
devversion,
jelbourn and
mmalerba
as
code owners
alan-agius4
force-pushed the
alan-agius4:ts4-build-refactor
branch
from
7a00768
to
d077b50
alan-agius4
force-pushed the
alan-agius4:ts4-build-refactor
branch
4 times, most recently
from
ac98274
to
3ada49d
|
LGTM. Nice that we were able to get rid of the duplication for both the mixins and accessors. A few minor comments |
alan-agius4
force-pushed the
alan-agius4:ts4-build-refactor
branch
2 times, most recently
from
997539c
to
b761cb2
alan-agius4
requested review from
jelbourn
and removed request for
andrewseguin and
mmalerba
|
Thanks @devversion & @jelbourn for the input and feedback. I’ll be doing the changes tomorrow. |
alan-agius4
changed the title
alan-agius4
force-pushed the
alan-agius4:ts4-build-refactor
branch
from
3f87438
to
5af1c73
alan-agius4
force-pushed the
alan-agius4:ts4-build-refactor
branch
2 times, most recently
from
49f9ea9
to
a23eb6f
|
@devversion & @jelbourn PTAL. Thanks. |
With this change we refactor the code to support compilation using TS 4.0. The main changes are: 1) Refactor tests to not delete non optional properties 2) Refactor components not to override properties with accessors and vice-versa which is now not permitted. https://devblogs.microsoft.com/typescript/announcing-typescript-4-0-beta/#breaking-changes
… to 10.1.0-next.8
alan-agius4
force-pushed the
alan-agius4:ts4-build-refactor
branch
from
5ce6cba
to
9f68ff2
|
LGTM, I'm running a google presubmit now |
|
Still LGTM from my side. Thanks Alan! |
jelbourn
merged commit f33210c
into
angular:master
15 checks passed
15 checks passed
ci/angular: merge status
All checks passed!
cla/google
All necessary CLAs are signed
annieyw
added a commit
to annieyw/components
that referenced
this pull request
Aug 31, 2020
With this change we refactor the code to support compilation using TS 4.0. 1) Refactor tests to not delete non optional properties 2) Refactor components not to override properties with accessors and vice-versa which is now not permitted. https://devblogs.microsoft.com/typescript/announcing-typescript-4-0-beta/#breaking-changes 3) update typescript to 4.0, tslint to 6.1.3 and angular packages to 10.1.0-next.8 4) add ts-compat integration test for TypeScript 3.9
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
With this change we refactor the code to support compilation using TS 4.0.
The main changes are: