Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upbuild: prevent bazel from logging warning on each invocation #19298
Conversation
Each time ibazel is run, it logs something like: ``` INFO: Build completed successfully, 14 total actions ################################################################################ # Did you know iBazel can invoke programs like Gazelle, buildozer, and # # other BUILD file generators for you automatically based on bazel output? # # Documentation at: https://github.com/bazelbuild/bazel-watcher#output-runner # ################################################################################ iBazel [3:24PM]: Use default regex ``` These changes avoid the annoying banner by adding a `.bazel_fix_commands.json` file according to https://github.com/bazelbuild/bazel-watcher#output-runner. Note that we it seems like we should be able to do the same by passing the `--run_output=false` flag, but I wasn't able to get it to work through the `.bazelrc`.
|
LGTM. Should we submit an issue upstream? I assume a comment in the file would be nice, but it's not JSON5 so we cannot right? |
|
I don't know whether we should file an issue, because it's documented which makes me think that it works this way on purpose. |
|
I don't think we should file an issue for the feature they are advertising for, but rather we should file an issue for the "ad banner" that is undesired in some Bazel projects. A way to reasonably disable the advertisement is not documented either. |
|
LGTM |
mmalerba
merged commit 9377b49
into
angular:master
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Each time ibazel is run, it logs something like:
These changes avoid the annoying banner by adding a
.bazel_fix_commands.jsonfile according to https://github.com/bazelbuild/bazel-watcher#output-runner. Note that we it seems like we should be able to do the same by passing the--run_output=falseflag, but I wasn't able to get it to work through the.bazelrc.