Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUI: Save Replay button stays at checked state #3116
Comments
|
Not quite sure why this button was configured to be checkable, but we have two options. Automatically uncheck it immediately after click, or remove this line: obs-studio/UI/window-basic-main.cpp Line 8210 in 5889e29 |
|
Possibly to account for a save action that takes long enough that retriggering save would be bad and we should indicate that to the user? Not entirely sure. It could also have just been "the other buttons are all checkable, so this one will be too". |
|
@RytoEX As far as I can tell, I don't think it's the former. It doesn't check the checked state before triggering, and you can mash the hotkey if you like. The function itself doesn't return anything either. The latter seems most likely. |


Platform
OS: Any
OBS Studio: v25.0.8+
Expected Behavior
The button should reset its state after the save replay buffer operation is complete.
Current Behavior
The button changes its state on each click.
Steps to Reproduce
Additional information
The checked button was used here to draw the button similar to "Pause" button of the casual recording:
https://github.com/obsproject/obs-studio/blob/e2fa510436b48d7bdfc1b76cf7bb2d2e4e57d304/UI/window-basic-main.cpp#L7622-#L7623
but for "Save Replay" the checked state is never resets on file operation complete.
The behavior can be visualized by the next changes to Themes (add code to the end of the any
.qssfile), just for example: