close
The Wayback Machine - https://web.archive.org/web/20201024120231/https://github.com/obsproject/obs-studio/issues/3116
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Save Replay button stays at checked state #3116

Open
SuslikV opened this issue Jul 1, 2020 · 3 comments
Open

UI: Save Replay button stays at checked state #3116

SuslikV opened this issue Jul 1, 2020 · 3 comments

Comments

@SuslikV
Copy link
Contributor

@SuslikV SuslikV commented Jul 1, 2020

Platform

OS: Any
OBS Studio: v25.0.8+

Expected Behavior

The button should reset its state after the save replay buffer operation is complete.

Current Behavior

The button changes its state on each click.

Steps to Reproduce

  1. Start Replay Buffer (new button to "Save Replay" will appear right to it).
  2. Click "Save Replay" button right to the Start Replay Buffer button.
  3. Despite existing UI themes lacks the "checked" icon state drawing, the enhanced (custom ones) clearly indicates that button stays checked until next mouse click.

Additional information

The checked button was used here to draw the button similar to "Pause" button of the casual recording:
https://github.com/obsproject/obs-studio/blob/e2fa510436b48d7bdfc1b76cf7bb2d2e4e57d304/UI/window-basic-main.cpp#L7622-#L7623

but for "Save Replay" the checked state is never resets on file operation complete.

The behavior can be visualized by the next changes to Themes (add code to the end of the any .qss file), just for example:

QPushButton[themeID="replayIconSmall"] {
	border-image: url(./Rachni/checkbox_checked.png);
}

QPushButton[themeID="replayIconSmall"]:checked {
	border-image: url(./Rachni/checkbox_checked_disabled.png);
}
@WizardCM WizardCM added the Confirmed label Sep 9, 2020
@WizardCM
Copy link
Collaborator

@WizardCM WizardCM commented Sep 9, 2020

Not quite sure why this button was configured to be checkable, but we have two options. Automatically uncheck it immediately after click, or remove this line:

replay->setCheckable(true);

@RytoEX
Copy link
Collaborator

@RytoEX RytoEX commented Sep 9, 2020

Possibly to account for a save action that takes long enough that retriggering save would be bad and we should indicate that to the user? Not entirely sure. It could also have just been "the other buttons are all checkable, so this one will be too".

@WizardCM
Copy link
Collaborator

@WizardCM WizardCM commented Sep 10, 2020

@RytoEX As far as I can tell, I don't think it's the former. It doesn't check the checked state before triggering, and you can mash the hotkey if you like. The function itself doesn't return anything either. The latter seems most likely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.