Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upguard canLoad(), incorrect return types #18751
Closed
Milestone
Comments
|
can i work on a PR for it? |
|
@geromegrignon, sure! |
geromegrignon
added a commit
to geromegrignon/angular-cli
that referenced
this issue
Sep 11, 2020
add UrlTree to canLoad guard signature to match the documentation and the other implementations Closes: angular#18751
clydin
added a commit
that referenced
this issue
Sep 11, 2020
clydin
added a commit
that referenced
this issue
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment


Command (mark with an
x)Is this a regression?
Probably notDescription
generating a guard with canLoad() method creates it with a wrong return type.ng g guard auth/test --implements CanLoadAnything else relevant?
The generated class:
Should be:
}
The return type is not correct, according to angular docs
| UrlTreeis missing