close
The Wayback Machine - https://web.archive.org/web/20201226184837/https://github.com/github/scientist/pull/121
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract logic that generates results from #run #121

Merged
merged 1 commit into from Aug 25, 2020

Conversation

@jejacks0n
Copy link
Contributor

@jejacks0n jejacks0n commented Aug 9, 2020

I'm working at getting Scientist utilized within the GitLab project because I think we can use it successfully in a couple of ways. (👋 hello fellow Git* person). One way is the standard usage, and the other is in a slightly more A/B/n capacity, which turns out is only subtly different in terms of how Scientist is implemented at a high level.

The main difference is in how one may want to generate results of an experiment. Currently Scientist has the concept of running all variants and comparing them in terms of performance and verifying that results match. This is obviously highly useful and will always be the primary usage, but a different approach could be to run a subset of variants, or a single variant -- let's say using Unleash behind the scenes to determine which one(s), and the rollout strategy.

I didn't change or add any tests because the behaviors are functionally unchanged, but I'd be happy to if there's any guidance in how you'd like to see it be tested.

Thanks for the work on maintaining this project!

@coveralls
Copy link

@coveralls coveralls commented Aug 9, 2020

Coverage Status

Coverage increased (+0.02%) to 99.107% when pulling b4790c2 on jejacks0n:extract-generating-results into 04dd1ba on github:master.

@zerowidth
Copy link
Member

@zerowidth zerowidth commented Aug 25, 2020

🆒, opening an extension point for overriding behavior sounds good.

@zerowidth zerowidth merged commit db8e2a5 into github:master Aug 25, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.