close
The Wayback Machine - https://web.archive.org/web/20220516011447/https://github.com/storybookjs/storybook/pull/11765
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source-loader: Fix storiesOf missing __STORY__ variable #11765

Merged
merged 2 commits into from Aug 3, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Aug 3, 2020

Issue: N/A

What I did

Fix storiesOf source bug introduced in #11707

Always generate preamble global vars to avoid warning. Real fix is to remove need for those vars, possibly in conjunction with removing storiesOf support.

How to test

See angular-cli

@shilman shilman added this to the 6.0 milestone Aug 3, 2020
@shilman
Copy link
Member Author

@shilman shilman commented Aug 3, 2020

Self-merging @tmeasday

@shilman shilman merged commit d95e93c into next Aug 3, 2020
7 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant