close
The Wayback Machine - https://web.archive.org/web/20260518134156/https://github.com/TheAlgorithms/Python/pull/2193
Skip to content

Hierarchical Clustering Addition #2193

Closed
BassCoder2808 wants to merge 2 commits into
TheAlgorithms:masterfrom
BassCoder2808:master
Closed

Hierarchical Clustering Addition #2193
BassCoder2808 wants to merge 2 commits into
TheAlgorithms:masterfrom
BassCoder2808:master

Conversation

@BassCoder2808
Copy link
Copy Markdown

@BassCoder2808 BassCoder2808 commented Jul 10, 2020

#2165 # Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@BassCoder2808 BassCoder2808 changed the title Hierarchical Clustering Addition #2165 Hierarchical Clustering Addition Jul 10, 2020
@TravisBuddy
Copy link
Copy Markdown

Hey @BassCoder2808,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: ba8f15f0-c2b5-11ea-bbc7-2b020bbf5e3a

Copy link
Copy Markdown
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As described in https://github.com/TheAlgorithms/Python/blob/master/CONTRIBUTING.md, this feels more like a how-to-use rather than an algorithm. No tests. No type hints. Codespell is failing. Travis CI is failing.
https://github.com/TheAlgorithms/Python/blob/master/Travis_CI_tests_are_failing.md

@l3str4nge l3str4nge added the awaiting changes A maintainer has requested changes to this PR label Jul 12, 2020
@stale
Copy link
Copy Markdown

stale Bot commented Aug 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale Used to mark an issue or pull request stale. label Aug 11, 2020
@stale
Copy link
Copy Markdown

stale Bot commented Aug 19, 2020

Please reopen this issue once you commit the changes requested or make improvements on the code. Thank you for your contributions.

@stale stale Bot closed this Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting changes A maintainer has requested changes to this PR stale Used to mark an issue or pull request stale.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants