close
The Wayback Machine - https://web.archive.org/web/20200920130906/https://github.com/Azure/setup-helm/pull/11
Skip to content

/ setup-helm

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the documentation to specify v before 'version' and code changes to append 'v' if it not provided in version #11

Merged
merged 4 commits into from May 14, 2020
Merged

Changed the documentation to specify v before 'version' and code changes to append 'v' if it not provided in version #11

merged 4 commits into from May 14, 2020

Conversation

@rgsubh
Copy link
Collaborator

rgsubh commented May 7, 2020

No description provided.

@rgsubh
Chnaged the documentation to sepcify v before 'version'
Loading status checks…
1a980ff
@rgsubh rgsubh requested a review from ds-ms May 7, 2020
@rgsubh rgsubh changed the title Chnaged the documentation to sepcify v before 'version' Changed the documentation to specify v before 'version' May 7, 2020
@ds-ms
ds-ms reviewed May 7, 2020
View changes
README.md Outdated Show resolved Hide resolved
@rgsubh
append v to version incase it does not already include
Loading status checks…
5801d81
@ds-ms
ds-ms requested changes May 11, 2020
View changes
src/run.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@rgsubh
review comments fix
Loading status checks…
d56b96d
@rgsubh rgsubh requested a review from ds-ms May 13, 2020
@rgsubh rgsubh changed the title Changed the documentation to specify v before 'version' Changed the documentation to specify v before 'version' and code changes to append 'v' if it not provided in version May 13, 2020
@ds-ms
ds-ms approved these changes May 13, 2020
View changes
Copy link
Contributor

ds-ms left a comment

LGTM! 🚀

Test E2E before merging! 😄
@rgsubh
Merge branch 'releases/v1' into docfix
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
59d5057
@rgsubh rgsubh merged commit 98b8d3a into releases/v1 May 14, 2020
1 check passed
1 check passed
license/cla All CLA requirements met.
Details
rgsubh added a commit that referenced this pull request May 14, 2020
@rgsubh
Changed the documentation to specify v before 'version' and code chan…
Loading status checks…
e045d11 
…ges to append 'v' if it not provided in version (#11)

* Chnaged the documentation to sepcify v before 'version'

* append v to version incase it does not already include

* review comments fix
@rgsubh rgsubh mentioned this pull request May 14, 2020
Merged
rgsubh added a commit that referenced this pull request May 14, 2020
@rgsubh
Changed the documentation to specify v before 'version' and code chan…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
91b7d21 
…ges to append 'v' if it not provided in version (#11) (#15)

* Chnaged the documentation to sepcify v before 'version'

* append v to version incase it does not already include

* review comments fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ds-ms ds-ms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@rgsubh @ds-ms
You can’t perform that action at this time.