Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport multiple registries #13
Merged
Conversation
msftclas
commented
Apr 28, 2020
•
|
|
|
Could you cherry-pick these changes to |
squarebracket
added a commit
to squarebracket/docker-login
that referenced
this pull request
May 7, 2020
|
Certainly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
squarebracket commentedApr 28, 2020
It's unclear to me on which branch you want pull requests. Let me know if I should be targeting master.
This PR adds support for multiple registries. It does so by reading in the
config.jsonpointed to byDOCKER_CONFIG, if it exists. If it does, itJSON.parses it and adds a new entry toauths. If it doesn't, or if there's any problem with reading in and setting the new key, it simply generates a newconfig.jsonand overwrites the old one.This differs from the current behavior, which writes a new file and simply changes the env var. If you think I should explicitly state this in the README, I'd be happy to add it.