Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPolygon Series #339
Merged
Polygon Series #339
Conversation
added 2 commits
Apr 3, 2017
src/plot/series/polygon-series.js
Outdated
| const DEFAULT_COLOR = '#12939A'; | ||
|
|
||
| function generatePath(data, xFunctor, yFunctor) { | ||
| const path = data.reduce((res, row, i) => { |
This comment has been minimized.
This comment has been minimized.
balthazar
Apr 3, 2017
Contributor
nit?
const generatePath = (data, xFunctor, yFunctor) =>
`${data.reduce((res, row, i) => `${res} ${i ? 'M' : 'L'}${xFunctor(row)}${yFunctor(row)}`)} Z`;
src/plot/series/polygon-series.js
Outdated
| onMouseOut: this._seriesMouseOutHandler, | ||
| onClick: this._seriesClickHandler, | ||
| fill: color || DEFAULT_COLOR, | ||
| style: { |
This comment has been minimized.
This comment has been minimized.
added 2 commits
Apr 3, 2017
mcnuttandrew
added a commit
to mcnuttandrew/react-vis
that referenced
this pull request
Apr 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mcnuttandrew commentedApr 3, 2017
•
edited
The polygon series allows users to specify arbitrary polygons in coordinates. This may seem un-useful, but it allows for easy creation of radar charts (#299), fancy mark series dots, and any variety of additional things you might need polygons for!