Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fix some of the resolver.reject's to return Error objects #118
Conversation
|
Hm, I forgot to reference #117 |
|
Looks great, thanks! |
briancavalier
added a commit
that referenced
this pull request
Jul 4, 2013
Fix some of the resolver.reject's to return Error objects
|
Yeah, the one in ComponentFactory is there for a specific reason and is never exposed to callers, and the sentinel values in the tests are specifically used for testing purposes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
There are two more rejects that I did not dare touch, as they seemed to return some objects of unspecified form instead of strings. Namely:
Line 36 in lib/ComponentFactory.js
and
Line 72 in lib/lifecycle.js
There are also some uses of "sentinel" as a reject reason in test/node/aop-test.js but since it's in the test it might not matter all that much.