close
The Wayback Machine - https://web.archive.org/web/20201215181643/https://github.com/python/pythondotorg/issues/560
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar event pages for full day event show (wrong) times #560

Open
malemburg opened this issue Feb 2, 2015 · 4 comments
Open

Calendar event pages for full day event show (wrong) times #560

malemburg opened this issue Feb 2, 2015 · 4 comments

Comments

@malemburg
Copy link
Member

@malemburg malemburg commented Feb 2, 2015

See e.g. https://www.python.org/events/python-events/246/

This is an event for the days March 28 and 29. The calendar entry uses all day entries for this, without specifying times on each day. Yet the python.org site displays "From 28 March at 12am UTC through 30 March at 12am UTC, 2015", so it's 12 hours off.

The all day event should really only show up as "From 28 March through 29 March".

The iCal entry for the events starts with:

BEGIN:VEVENT
DTSTART;VALUE=DATE:20150328
DTEND;VALUE=DATE:20150330
DTSTAMP:20150202T092425Z
...

without timezone information.

@malemburg
Copy link
Member Author

@malemburg malemburg commented Nov 30, 2016

This problem keeps popping up again and again for full day events (all conferences we add to the Google calendars), e.g. most recently here:

https://www.python.org/events/python-events/467/

The event is from April 3-7 and shown correctly in the Google calendar widget:

http://www.pycon.org/#calendar

berkerpeksag added a commit to berkerpeksag/pythondotorg that referenced this issue Sep 12, 2018
* Make the event importer to exclude the ending day in
  case of a full day event
* Don't create a datetime instance from a date object if an
  event is a full day event

Fixes python#375 
Fixes python#560
@malemburg
Copy link
Member Author

@malemburg malemburg commented Dec 18, 2018

This bug still exists: https://www.python.org/events/python-events/800/ vs. http://www.pycon.org/#calendar

The problem is that full day events should be displayed using times (or time zones for that matter), but just the dates, which are correctly entered into the Google calendars.

@malemburg malemburg reopened this Dec 18, 2018
@berkerpeksag
Copy link
Member

@berkerpeksag berkerpeksag commented Dec 18, 2018

IIRC, this hasn't been deployed to production yet. Could you please check it at staging.python.org?

@malemburg
Copy link
Member Author

@malemburg malemburg commented Dec 18, 2018

Looks fine for EuroPython on staging: https://staging.python.org/events/python-events/794/

So I guess all that needs to be done is deploy on production :-)

Thanks, Berker !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.