close
Skip to content

Fix unbound exc in babel.dates #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akx merged 1 commit into from
Jan 25, 2023
Merged

Fix unbound exc in babel.dates #959

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions babel/dates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,18 +243,17 @@ def get_timezone(zone: str | datetime.tzinfo | None = None) -> datetime.tzinfo:
if not isinstance(zone, str):
return zone

exc = None
if pytz:
try:
return pytz.timezone(zone)
except pytz.UnknownTimeZoneError as exc: # noqa: F841
pass
except pytz.UnknownTimeZoneError as e:
exc = e
Comment on lines +249 to +250
Copy link
Copy Markdown
Contributor

@DenverCoder1 DenverCoder1 Jan 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the variable is not used, can't it be removed?

Suggested change
except pytz.UnknownTimeZoneError as e:
exc = e
except pytz.UnknownTimeZoneError:
pass

else:
assert zoneinfo
try:
return zoneinfo.ZoneInfo(zone)
except zoneinfo.ZoneInfoNotFoundError as exc: # noqa: F841
pass
except zoneinfo.ZoneInfoNotFoundError as e:
exc = e

raise LookupError(f"Unknown timezone {zone}") from exc

Expand Down