feat: support --custom-header flags#5127
Merged
Merged
Conversation
klauspost
reviewed
Feb 10, 2025
harshavardhana
requested changes
Feb 10, 2025
ramondeklein
requested changes
Feb 10, 2025
1e9ee66 to
a3fd0b5
Compare
7b7d191 to
c8eed15
Compare
Contributor
|
This is worse now. @ramondeklein was this what you meant? |
Contributor
|
@klauspost No. There should be a better way to provide CLI parameters. A 200 file change PR is not acceptable. I've not the time to work on this, but it's hard to believe we need to change 200 files to send a custom header... |
7a92ee9 to
4350d40
Compare
212b74d to
b86dbf8
Compare
add custom-header flags
3d604ed to
1e5d857
Compare
harshavardhana
approved these changes
Feb 13, 2025
Co-authored-by: Ramon de Klein <mail@ramondeklein.nl>
klauspost
approved these changes
Feb 13, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
support header flags
Allows user use
--custom-header="HeaderA:ValueA" --custom-header="HeaderB:ValueB"to sent custom header to S3.Motivation and Context
How to test this PR?
mc ls minio --custom-header "MyHeaderA:Value" --custom-header "MyHeaderB:Value" --debugTypes of changes
Checklist:
commit-idorPR #here)