fix: remove set active from set password#806
Conversation
|
🐕 Review complete — View session on Shuni Portal 🐾 |
There was a problem hiding this comment.
🐕 Shuni's Review
Removes the unused set_active parameter from the deprecated set_password() method, since the backend ignores it. The newer set_temporary_password and set_active_password methods already handle this correctly via dedicated endpoints.
No issues found — good bones! Clean removal with test updated to match. Woof!
There was a problem hiding this comment.
Pull request overview
Removes the unused set_active/setActive flag from the deprecated management API mgmt.user.set_password() to align the client with backend behavior (related to issue #14914).
Changes:
- Remove the
set_activeparameter fromUser.set_password()and stop sendingsetActivein the request body. - Update the
set_password()docstring to reflect that the password is always set as expired. - Update the corresponding unit test to match the new request payload.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
descope/management/user.py |
Removes set_active from the public method signature, request body, and updates the docstring. |
tests/management/test_user.py |
Updates test_user_set_password to no longer expect setActive in the JSON payload. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage reportThe coverage rate went from None of the new lines are part of the tested code. Therefore, there is no coverage data about them. |
Related Issues
related to https://github.com/descope/etc/issues/14914
Description
Removes the set_active parameter from mgmt.user.set_password() as it is not used by the backend and had no effect.
Must